Problem with NumericColumn sorting

Pawel_Reise · February 26, 2014, 6:09pm

Hi,

I'm preparing a custom report and I'm trying to make sorting by numbers
work. Here is the report I'm talking about:
https://github.com/dimagi/commcare-hq/blob/master/custom/m4change/reports/immunization_hmis_report.py.
As it is, sorting works fine, but only for strings. When I try to change
column type in the headers from DataTablesColumn to NumericColumn, it
doesn't sort this column anymore. I can keep clicking on header but the
numbers are not being sorted properly (angle bracket next to the header
name does toggle its direction though). Do you happen to know if there
is a need to add something more in order to make NumericColumn sorting work?

Best regards
Pawel

czue · February 26, 2014, 8:13pm

Hi Pawel,

When you use a different sort type you need to have the data stored as
tuples using something like this:

github.com

dimagi/commcare-hq/blob/master/corehq/apps/reports/util.py#L231


      
                      is_active=user.get('is_active', None),
                      location_id=user.get('location_id', None)
                  )
                  if '__group_ids' in user:
                      group_ids = user['__group_ids']
                      info.__group_ids = group_ids if isinstance(group_ids, list) else [group_ids]
                  return info
          
          
          # TODO: This is very similar code to what exists in apps/users/util/user_display_string
          def _get_username_fragment(username, first='', last=''):
              full_name = ("%s %s" % (first, last)).strip()
          
              result = username
              if full_name:
                  result = '{} "{}"'.format(result, full_name)
          
              return result
          
          
          def get_simplified_users(user_es_query):

There are lots of numeric sort examples in the sms reports here:

github.com

dimagi/commcare-hq/blob/master/corehq/apps/reports/standard/sms.py

from collections import namedtuple
from datetime import datetime

from django.conf import settings
from django.core.exceptions import ObjectDoesNotExist
from django.db.models import Count, F, Q
from django.http import Http404, HttpResponseRedirect
from django.urls import reverse
from django.utils.functional import cached_property
from django.utils.html import format_html
from django.utils.translation import gettext as _
from django.utils.translation import gettext_lazy, gettext_noop

from couchdbkit import ResourceNotFound
from memoized import memoized

from corehq import toggles
from corehq.apps.casegroups.models import CommCareCaseGroup
from corehq.apps.data_interfaces.models import AutomaticUpdateRule
from corehq.apps.data_interfaces.views import CaseGroupCaseManagementView

This file has been truncated. show original

cheers,
Cory

···

On Wed, Feb 26, 2014 at 12:09 PM, Paweł Reise wrote:

Hi,

I'm preparing a custom report and I'm trying to make sorting by numbers
work. Here is the report I'm talking about: Dimagi · GitHub
commcare-hq/blob/master/custom/m4change/reports/
immunization_hmis_report.py. As it is, sorting works fine, but only for
strings. When I try to change column type in the headers from
DataTablesColumn to NumericColumn, it doesn't sort this column anymore. I
can keep clicking on header but the numbers are not being sorted properly
(angle bracket next to the header name does toggle its direction though).
Do you happen to know if there is a need to add something more in order to
make NumericColumn sorting work?

Best regards
Pawel

--

--- You received this message because you are subscribed to the Google
Groups "CommCare Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to commcare-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.